Thread: More Intelligent Python file manipulation

trying find better way manage files here code snippet
code works, me think sloppy. trying make multiple entries while inputing variables in middle of string on 1 line. assign file variable , add function mail sendmail function made body=""

code:

 ##### lets see if have errors in our file... if lets email beotch  #### otherwise lets append our server completion list!! when reach last #server email total list   message_size = os.stat("/tmp/errors").st_size   completed_size = os.stat("/tmp/completed").st_size       if message_size != 0:     messages = open("/tmp/errors", "r")     message = messages.read()     messages.close()     mail(body=message)   else:     if completed_size == 0:       completed.write("the following servers completed copying logs successfully\n\n")         completed.write(server)       completed.write(" copied ")       completed.write(cpy_count)       completed.write(" out of ")       completed.write(base_count)       completed.write(" files. total size of logs ")       completed.write(file_sizes)       completed.write("\n")     else:       if server != "final_server_on_list":         completed.write(server)         completed.write(" copied ")         completed.write(cpy_count)         completed.write(" out of ")         completed.write(base_count)         completed.write(" files. total size of logs ")         completed.write(file_sizes)         completed.write("\n")       else:         completed.write(server)         completed.write(" copied ")         completed.write(cpy_count)         completed.write(" out of ")         completed.write(base_count)         completed.write(" files. total size of logs ")         completed.write(file_sizes)         completed.close()         completed = open("/tmp/completed", "r")         complete = completed.read()         mail(body=complete)         completed.close()         completed = open("/tmp/completed", "w")       completed.close()

code:

 ##### lets see if have errors in our file... if lets email beotch  #### otherwise lets append our server completion list!! when reach last #server email total list   message_size = os.stat("/tmp/errors").st_size   completed_size = os.stat("/tmp/completed").st_size  # declaret strings can concatenate server = str() cpy_count = str() base_count = str() file_sizes  = str()    if message_size != 0:     messages = open("/tmp/errors", "r")     message = messages.read()     messages.close()     mail(body=message)   else:     if completed_size == 0:       msg = "the following servers completed copying logs successfully\n\n"       completed.write(msg + server + " copied " + cpy_count + " out of " + base_count + " files. total size of logs " + file_sizes + "\n")     else:       if server != "final_server_on_list":         completed.write(server + " copied " + cpy_count + " out of " + base_count + " files. total size of logs " + file_sizes + "\n"  )       else:         completed.write(server + " copied " + cpy_count +  " out of " + base_count + " files. total size of logs " + file_sizes )         completed.close()         completed = open("/tmp/completed", "r")         complete = completed.read()         mail(body=complete)         completed.close()         completed = open("/tmp/completed", "w")       completed.close()

try this, hope works, can replace else if elif
dont understand try accomplish on last part of code, dont know.

Forum The Ubuntu Forum Community Ubuntu Specialised Support Development & Programming Programming Talk [SOLVED] More Intelligent Python file manipulation

Ubuntu